Sent January 31, 2006
Hi,
I submitted a patch today Here's an outline of how you should progress in the coming weeks:
1. Write your conformance test, which you'll submit to Wine first. The feature isn't implemented yet, so todo_wine{} blocks should be sprinkled in your code to mark tests that currently fail under Wine. See this page for coding hints:
http://wiki.jswindle.com/index.php/Coding_Hints:Test_Cases
2. Generate a patch for your conformance test (with corresponding ChangeLog entry) and send it to the cs130 list for code review. Your patch should look something like this:
http://www.seas.ucla.edu/~kho/wine/patches/riched20_scrollcaret_conftest-20060131.patch
Once it passes muster, submit it to wine-patches.
3. At the same time as (1), you should start thinking about implementing your feature. After you implement your feature, your conformance test should fail since the tests in the todo_wine{} blocks now pass. Getting rid of the todo_wine{} guards, your patch should look something like this:
http://www.seas.ucla.edu/~kho/wine/patches/riched20_scrollcaret_featureimpl-20060131.patch
Don't hesitate to ask questions [to the list], and get hacking!
-Tommy
P.S. I have a lot of code written, but not ready to submit. In fact, your test might have been half-written already. You can look here:
http://www.seas.ucla.edu/~kho/wine/patches/riched20_test_20060131_full.patch